madhushreeag commented on code in PR #43337:
URL: https://github.com/apache/superset/pull/43337#discussion_r3823907324
##########
superset/common/query_object.py:
##########
@@ -545,12 +546,19 @@ def exec_post_processing(self, df: DataFrame) ->
DataFrame:
_("`operation` property of post processing object
undefined")
)
if not hasattr(pandas_postprocessing, operation):
Review Comment:
Six names are reachable via hasattr but not in __all__ - Dispatch now gates
on __all__ instead of hasattr, so it matches what the schema validates against
and what the startup collision check warns about.
The new tests catch the bug by stashing the fix, all 6 parametrized cases
fail on the old hasattr dispatch and pass with the fix in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
