rusackas commented on PR #43337: URL: https://github.com/apache/superset/pull/43337#issuecomment-5347960715
A couple of small things worth cleaning up sometime, neither blocking: the `getattr(fn, "__name__", None)` extraction is duplicated between `schemas.py` and `query_object.py`, could be one shared helper. Also, a custom op that happens to share a name with a builtin (say someone registers their own `aggregate`) silently never fires, since builtins are checked first. Might be worth a startup-time warning eventually. Feel free to leave both for a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
