sadpandajoe commented on code in PR #36350:
URL: https://github.com/apache/superset/pull/36350#discussion_r3824449063
##########
superset-frontend/src/components/Chart/chartReducer.ts:
##########
@@ -75,6 +75,7 @@ export default function chartReducer(
chartUpdateEndTime: null,
chartUpdateStartTime: now(),
queryController: action.queryController,
+ latestQueryId: action.latestQueryId,
Review Comment:
Starting a replacement query overwrites this only copy of the prior client
ID, while the caller aborts only the prior browser request. The first database
query therefore keeps running and the Stop button can only address the new ID.
Should the supersession path send cancellation for the previous ID before
discarding it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
