sadpandajoe commented on code in PR #36350:
URL: https://github.com/apache/superset/pull/36350#discussion_r3824459445
##########
superset/charts/schemas.py:
##########
@@ -1535,6 +1535,12 @@ class ChartDataQueryContextSchema(Schema):
form_data = fields.Raw(allow_none=True, required=False)
+ client_id = fields.String(
Review Comment:
This accepts an unbounded client ID, but the persisted `Query.client_id` is
`String(11)`. A longer API-supplied value makes the best-effort row insert fail
on strict metadata databases; the chart still runs, but it has no cancellation
record and Stop returns not found. Should this validate the 11-character
persistence limit before starting the query?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
