aminghadersohi commented on PR #43338: URL: https://github.com/apache/superset/pull/43338#issuecomment-5361162403
Addressed all feedback from the latest review in `50bc58fb8f`: - bridge both saved-query-context and form-data SQL paths through `set_query_context_form_data`, so Jinja `get_time_filter()` sees and can consume temporal filters; - propagate normalized query `extras`, including `relative_start` and `relative_end`, into saved and freshly built query objects; - translate malformed nested filter containers and Marshmallow schema failures into structured `ChartError(error_type="ValidationError")` responses at the normalization/load boundaries; - removed the broad top-level `KeyError` handler so unrelated key errors are not mislabeled as malformed `extra_form_data`; - added regression coverage for relative-time extras and the request-local form-data bridge. Validation: staged-file pre-commit passed mypy, ruff-format, ruff, and all other available hooks. The pylint hook could not run because `pylint` is not installed in this environment. Targeted pytest collection is also blocked by the environment's incompatible/missing `sqlglot.dialects.singlestore` module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
