aminghadersohi commented on PR #43338: URL: https://github.com/apache/superset/pull/43338#issuecomment-5372751145
Addressed the approver's final suggestions: - saved-query-context validation failures retain diagnostics via a warning log before falling back to form data; - fallback validation errors no longer blame `extra_form_data` specifically and instead report generic invalid chart query data, avoiding misclassification of unrelated form-data/query-construction problems; - added an assertion covering the preserved stale-context diagnostic; - updated the PR summary to document that the shared helper also propagates relative-time extras for `get_chart_data`. All staged-file pre-commit hooks pass, including mypy, ruff-format, ruff, and pylint. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
