codeant-ai-for-open-source[bot] commented on code in PR #43268: URL: https://github.com/apache/superset/pull/43268#discussion_r3825030760
########## superset/mcp_service/app.py: ########## @@ -417,17 +421,17 @@ def get_default_instructions( Chart Types in Existing Charts (viewable via list_charts/get_chart_info): Each chart returned by list_charts / get_chart_info includes a chart_type_display_name field with a human-readable name when available. -This field is populated only for the 10 chart types supported by generate_chart +This field is populated for the chart types supported by generate_chart (xy, pie, table, pivot_table, big_number, mixed_timeseries, handlebars, -histogram, box_plot, waterfall). +histogram, box_plot, waterfall, and host-gated interactive_pivot when enabled). For all other viz_types (Funnel, Gauge, Heatmap, etc.) it will be null โ use the raw viz_type field instead when referring to those chart types. Review Comment: **Suggestion:** The instructions claim `chart_type_display_name` is populated for `interactive_pivot` only when the host feature is enabled, but `display_name_for_viz_type()` searches registered plugins without checking `is_available()`. On an OSS deployment with the feature disabled, existing `ag-grid-pivot-table` charts can still receive the Interactive Pivot display name, contradicting this guidance. Either make display-name lookup availability-aware or remove the host-gated qualification. [docstring mismatch] <details> <summary><b>Severity Level:</b> Minor ๐งน</summary> ```mdx - โ ๏ธ Disabled Interactive Pivot charts still receive display names. - โ ๏ธ MCP guidance misdescribes chart metadata behavior. - โ ๏ธ Existing registry tests intentionally confirm unfiltered lookup. ``` </details> [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/mcp_service/app.py **Line:** 424:428 **Comment:** *Docstring Mismatch: The instructions claim `chart_type_display_name` is populated for `interactive_pivot` only when the host feature is enabled, but `display_name_for_viz_type()` searches registered plugins without checking `is_available()`. On an OSS deployment with the feature disabled, existing `ag-grid-pivot-table` charts can still receive the Interactive Pivot display name, contradicting this guidance. Either make display-name lookup availability-aware or remove the host-gated qualification. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43268&comment_hash=63b94b775eb67ceeef1615f1abe1dfa9b13aa5d0ce4b500111a807a687b0ef8c&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43268&comment_hash=63b94b775eb67ceeef1615f1abe1dfa9b13aa5d0ce4b500111a807a687b0ef8c&reaction=dislike'>๐</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
