aminghadersohi commented on PR #43268: URL: https://github.com/apache/superset/pull/43268#issuecomment-5372747218
Addressed the remaining review concerns in `895af43772`: - Changed the disabled-chart validation detail to the neutral “not available on this instance” wording, covering both operator filtering and host-unavailable visualizations. - Removed unsupported Interactive Pivot time-comparison controls and claims throughout schema discovery, mapping, examples, docs, and tests. - Added focused unit coverage for Interactive Pivot UI-config preservation/merge behavior in `test_chart_utils.py`; saved-update and cached-preview integration coverage remains in the feature/tool tests. - Renamed the all-feature-flags schema fixture to reflect its actual scope. I agree the pre-existing `ag-grid-table` native-viz gating gap is worth a separate follow-up. It needs variant-level availability within the `table` chart type rather than this PR’s chart-type-level hook, so I have kept that scope separate to avoid changing the stable table adapter here. Validation: full MCP chart suite **1,307 passed**, focused review suite **226 passed**, and changed-file pre-commit hooks passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
