gabotorresruiz commented on PR #42659: URL: https://github.com/apache/superset/pull/42659#issuecomment-5361567621
Hey Amin, I went to re-review and hit a surprise: `8a01ea6fdc` looks great but it never made it onto the PR branch. The current head `b36d56e` is only a master merge on top of `e076608`; the PR's own files are unchanged, `8a01ea6fdc` is not in the PR's commit list, and on GitHub it is not the head of any branch in your fork. I re-ran my live check against a build of the current head and the shared state is still dropped, while the same harness with `8a01ea6fdc` applied on top passes everything: permalink-only, identifier plus permalink_key, shared URL as identifier, and the typo error message all behave exactly as your replies describe, and 11 of the 13 new tests fail without the source fix, so they pin it properly. It also applies cleanly onto the current head. Looks like the push went missing; once it is on the branch and CI is green I am happy to approve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
