aminghadersohi commented on PR #42659: URL: https://github.com/apache/superset/pull/42659#issuecomment-5364786401
Thanks for the careful re-check — and good news: the commit is on the branch, it just has a new SHA. I rebased onto master, which rewrote `8a01ea6fdc` into **`b6cb9c91bc`** (same author, same subject, same content) and dropped the old merge-based history including `b36d56e`. That is exactly why your checks came back the way they did: `8a01ea6fdc` is not in the commit list and is not the head of any branch in my fork, because the rebase gave that work a different SHA. From the PR timeline: - `head_ref_force_pushed` -> `b6cb9c91bc` at `2026-08-20T17:36:06Z` - master merge `277855578a` at `2026-08-20T21:21:53Z` Current head is `277855578a`. Ancestry on that head: - `b6cb9c91bc` — ancestor (the fix) - `b36d56e` — not an ancestor (force-pushed away) - `8a01ea6fdc` — not an ancestor (rewritten by the rebase) I diffed the current PR head against my local branch across all eight files in the PR diff and they are byte-identical: ``` superset/mcp_service/dashboard/permalink.py superset/mcp_service/dashboard/schemas.py superset/mcp_service/dashboard/tool/get_dashboard_info.py superset/mcp_service/dashboard/tool/get_dashboard_layout.py tests/unit_tests/mcp_service/dashboard/test_permalink.py tests/unit_tests/mcp_service/dashboard/test_dashboard_schemas.py tests/unit_tests/mcp_service/dashboard/tool/test_dashboard_tools.py tests/unit_tests/mcp_service/dashboard/tool/test_get_dashboard_layout.py ``` So the state your harness validated with `8a01ea6fdc` applied on top is the state already on the branch. Re-running against `277855578a` should show all four scenarios passing and the 13 new tests green. On CI: 45 checks pass, one fails — `docker-build (lean)`, for two unrelated environmental reasons: - `##[error]Username and password required` — Docker Hub login, secrets are not exposed to fork PRs - `E: Failed to fetch .../chrome-stable/... File has unexpected size (1415 != 1416). Mirror sync in progress?` — transient apt mirror `docker-build (dev)` passed, as did `unit-tests`, `test-postgres`, both Playwright matrices, Cypress, and the license check. Nothing in that failure touches the Python changes here. Sorry for the confusion the force-push caused — happy to re-run anything you want against the current head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
