sha174n commented on PR #42760: URL: https://github.com/apache/superset/pull/42760#issuecomment-5368859818
Went through the cache-key construction for cross-context correctness and it holds up: the value key derives from a per-context bucket, and for the default EXECUTION_CONTEXT scope that bucket folds in principal, role ids, the datasource RLS cache key, and the guest token, which lines up with how the ordinary result cache partitions results; nice that it fails closed when there's no request context or resolvable principal, and that provider opt-in is required. The bounded-descriptor eviction now cleans up orphaned value keys too. One doc line worth making explicit: GLOBAL scope intentionally drops the per-context material, so it's only appropriate when a provider's results are provably identical across every principal and tenant. LGTM once rebased. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
