mikebridge commented on PR #42760: URL: https://github.com/apache/superset/pull/42760#issuecomment-5446160779
Rebased onto master `0597f36bb6` (@rusackas — two additive collisions: `docs/static/feature-flags.json`, regenerated from `config.py`; and `QueryResult.__init__`, where master added `sql_shifted_temporal_labels` next to our field) and addressed @sadpandajoe's three findings — replies inline. Head is `7eb97a33a3`. One API-shape change to flag for anyone tracking the response: the per-query field is renamed `semantic_cache_hit: bool` → `semantic_cache_status: "HIT" | "MISS" | "MIXED"` so a time-comparison chart can report mixed provenance. The header vocabulary is unchanged. @rusackas — the CI nit was already handled before this round: `scripts/change_detector.py` has a `semantic-layers` pattern set and `test-semantic-cache-coordination` gates on it, so it runs only when `superset/semantic_layers/`, `superset-core/.../semantic_layers/`, their tests, or the workflow itself change. Verification: the affected unit suites pass locally (semantic_layers, query cache manager, query context processor, chart-data API, initialization — 754 tests, 17 new); frontend type check, ChartPills jest, oxlint, ruff, mypy, and pylint are clean. *Fixes and write-up produced with AI assistance (Claude); verified locally as described.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
