villebro commented on code in PR #43434:
URL: https://github.com/apache/superset/pull/43434#discussion_r3839161882
##########
superset-websocket/src/index.ts:
##########
@@ -670,8 +592,8 @@ if (startServer) {
httpServer.listen(opts.port);
logger.info(`Server started on port ${opts.port}`);
- // start reading from event stream
- subscribeToGlobalStream(GLOBAL_EVENT_STREAM_NAME, processStreamResults);
+ // start receiving realtime messages from Redis Pub/Sub
+ subscribeToChannels();
Review Comment:
Fixed in a2ab07506a. `subscribeToChannels` now logs the failure and retries
(and binds the `pmessage` router only once so retries can't stack duplicate
listeners); ioredis also auto-resubscribes across reconnects. Delivery stays
best-effort by design — the browser's `status_changes` interval poll is the
correctness backstop, so startup is not aborted for an optional acceleration
transport.
##########
superset-websocket/src/config.ts:
##########
@@ -144,11 +144,10 @@ function applyEnvOverrides(config: ConfigType):
ConfigType {
LOG_LEVEL: val => (config.logLevel = val),
LOG_TO_FILE: val => (config.logToFile = toBoolean(val)),
LOG_FILENAME: val => (config.logFilename = val),
- REDIS_STREAM_PREFIX: val => (config.redisStreamPrefix = val),
- REDIS_STREAM_READ_COUNT: val =>
- (config.redisStreamReadCount = toNumber(val)),
- REDIS_STREAM_READ_BLOCK_MS: val =>
- (config.redisStreamReadBlockMs = toNumber(val)),
+ ENTITY_CHANGES_CHANNEL_PREFIX: val =>
+ (config.entityChangesChannelPrefix = val),
+ PER_PRINCIPAL_CHANNEL_PREFIX: val =>
+ (config.perPrincipalChannelPrefix = val),
Review Comment:
Good catch — fixed in a2ab07506a by removing the independent overrides. The
prefixes (`entity-changes:` / `realtime:`) are a wire-protocol contract with
the Python producer (`TaskManager.ENTITY_CHANGES_CHANNEL_PREFIX` /
`REALTIME_CHANNEL_PREFIX`), not a deployment knob, so they're now fixed
constants in the Node server (config keys, env overrides, and example/README
references dropped) that must stay in lockstep with the producer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
