villebro commented on PR #43434: URL: https://github.com/apache/superset/pull/43434#issuecomment-5387547396
Thanks for the reviews — both findings were valid and are addressed in a2ab07506a: 1. **Fire-and-forget subscription** (flagged by both bito and CodeAnt): `subscribeToChannels` no longer starts unawaited without error handling. It now logs the failure and retries (binding the `pmessage` router exactly once so retries can't stack duplicate listeners), and ioredis auto-resubscribes across reconnects. I deliberately did **not** abort startup on failure: the WebSocket transport is a best-effort *acceleration* layer, and the browser's `status_changes` interval poll (shipped earlier in this epic) is the correctness backstop — so a transient Redis hiccup degrades to polling rather than taking the server down. 2. **Configurable channel prefixes with no producer counterpart** (CodeAnt): removed the independent Node-side `entityChangesChannelPrefix`/`perPrincipalChannelPrefix` config + env overrides. They are a wire-protocol contract with the Python producer (`TaskManager.ENTITY_CHANGES_CHANNEL_PREFIX` / `REALTIME_CHANNEL_PREFIX`), not a deployment knob, so they're now fixed constants that must stay in lockstep with the producer (example config + README updated to match). tsc / eslint / oxfmt / all 46 Node tests green after the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
