bito-code-review[bot] commented on PR #43465:
URL: https://github.com/apache/superset/pull/43465#issuecomment-5398026686
<!-- Bito Reply -->
The review comment correctly identifies an issue: the `useListViewResource`
hook expects a plural resource label for error messages, but the current
implementation passes the singular `datasetLabel()`, which causes incorrect
pluralization (e.g., "Datasourcess").
To resolve this, you should pass a dedicated plural label to the hook for
error handling while continuing to use the singular label for UI display. You
can update the `ArchivedListBody` component to accept or derive the appropriate
plural form based on the current type.
Would you like me to fetch all other comments on this PR to validate and
implement fixes for them as well?
**superset-frontend/src/pages/ArchivedList/index.tsx**
```
refreshData,
} = useListViewResource<ArchivedItem>(
config.resource,
type === 'dataset' ? t('Datasets') : TYPE_LABELS[type](),
addDangerToast,
true,
[],
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
