codeant-ai-for-open-source[bot] commented on code in PR #43465:
URL: https://github.com/apache/superset/pull/43465#discussion_r3845307630
##########
superset-frontend/src/pages/ArchivedList/index.tsx:
##########
@@ -166,7 +169,7 @@ function ArchivedListBody({
refreshData,
} = useListViewResource<ArchivedItem>(
config.resource,
- TYPE_LABELS[type],
+ TYPE_LABELS[type](),
Review Comment:
**Suggestion:** The list hook treats its second argument as a plural
resource label and constructs list errors by appending a literal `s`. Passing
the singular, feature-dependent `datasetLabel()` causes dataset fetch errors to
bypass the shared plural translation (`Datasets`/`Datasources`) and can produce
incorrect or untranslated messages, especially for non-English locales. Pass
the appropriate plural label separately for list errors while retaining the
singular label for row and info copy. [api mismatch]
<details>
<summary><b>Severity Level:</b> Minor 🧹</summary>
```mdx
- ❌ Dataset list failures display the malformed “Datasourcess” label.
- ⚠️ Archived-list fetch errors have incorrect plural localization.
- ⚠️ Users receive misleading error-toast wording during API failures.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=eeb103afd8004a7ea6f2aed338ceaa1f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=eeb103afd8004a7ea6f2aed338ceaa1f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/pages/ArchivedList/index.tsx
**Line:** 172:172
**Comment:**
*Api Mismatch: The list hook treats its second argument as a plural
resource label and constructs list errors by appending a literal `s`. Passing
the singular, feature-dependent `datasetLabel()` causes dataset fetch errors to
bypass the shared plural translation (`Datasets`/`Datasources`) and can produce
incorrect or untranslated messages, especially for non-English locales. Pass
the appropriate plural label separately for list errors while retaining the
singular label for row and info copy.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43465&comment_hash=cf7afa9b1d950ea811df86f7b41c2ae2cdf0b24ca8a9de7399983cacdd9470c3&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43465&comment_hash=cf7afa9b1d950ea811df86f7b41c2ae2cdf0b24ca8a9de7399983cacdd9470c3&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
