bito-code-review[bot] commented on PR #43471: URL: https://github.com/apache/superset/pull/43471#issuecomment-5398447765
<!-- Bito Reply --> The flagged issue regarding the non-idempotent registration of the `SavedQuery` listener is correct. Because `sync_config_to_db()` can be called multiple times, registering the listener directly leads to duplicate callbacks, which are not fully cleaned up by `clear_sqla_event_listeners()`. To resolve this, you should register and remove the `SavedQuery` listener using the same declaration-based helper used for other listeners. Since the relevant code is not fully visible in the provided diff, please ensure you update the registration logic in `superset/app.py` or the corresponding core tagging module to use the centralized `register_sqla_event_listeners` helper. Regarding other comments on this PR, there are no additional review comments in the provided `pr_comments.csv` file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
