sadpandajoe commented on code in PR #43471: URL: https://github.com/apache/superset/pull/43471#discussion_r3855921802
########## superset/tags/core.py: ########## @@ -54,80 +54,40 @@ def _tag_delete_listener_declarations() -> tuple[DeleteListenerDeclaration, ...] def register_sqla_event_listeners() -> None: + """Register cleanup of ``tagged_object`` rows on object deletion. + + Only deletion is handled here: Superset no longer auto-generates Review Comment: Upgrades retain existing `editor:` and `favorited_by:` associations as queryable rows, but this removes the update and favorite listeners that kept them current. Changing an asset's editors or unfavoriting it after upgrading therefore leaves tag lookups reporting relationships that no longer exist. Should we clear these legacy associations during upgrade or continue maintaining them while they remain queryable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
