rusackas opened a new pull request, #43474: URL: https://github.com/apache/superset/pull/43474
### SUMMARY Two follow-ups on the semantic-layer/theme access-check work from #43389, for consistency: - `_serialize_layer`'s `configuration` blob is now passed through a masking step before it's returned. A connector publishes its configuration shape via `get_configuration_schema`; any property marked `"writeOnly": true` (the standard JSON Schema way of flagging a field that's set but never echoed back, e.g. a password or API key) gets replaced with the same `PASSWORD_MASK` used elsewhere in the codebase, rather than returned as-is. - `get_list`, `get`, and `runtime_schema` now carry the same `SEMANTIC_LAYERS` feature-flag guard that `structure`, `views`, and `delete` already have, so the flag gating is consistent across the whole API surface. Behavior is unchanged for connectors that don't mark any config field `writeOnly`. ### TESTING INSTRUCTIONS `pytest tests/unit_tests/semantic_layers/` — new unit tests for `_mask_configuration` (redacts marked fields, leaves unset/falsy values alone, no-ops when there's no registered connector or the schema can't be loaded) and for the three new feature-flag guards (both through the client and via direct unwrapped calls, matching the existing pattern for the other guarded endpoints). ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
