bito-code-review[bot] commented on code in PR #43474:
URL: https://github.com/apache/superset/pull/43474#discussion_r3847325587
##########
superset/semantic_layers/api.py:
##########
@@ -677,6 +711,9 @@ def runtime_schema(self, uuid: str) -> FlaskResponse:
404:
$ref: '#/components/responses/404'
"""
+ if not is_feature_enabled("SEMANTIC_LAYERS"):
Review Comment:
<!-- Bito Reply -->
The suggestion to extract the authorization check into a helper method is a
valid approach to improve maintainability by reducing code duplication. While
the pattern may predate this pull request, addressing it now would improve the
consistency of the codebase. You are not required to apply this suggestion if
it is out of scope for your current task, but it remains a sound recommendation
for future refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
