aminghadersohi commented on PR #42659: URL: https://github.com/apache/superset/pull/42659#issuecomment-5399452971
Superseded by #43482. This PR could not be reopened: the source fork repository was deleted, and GitHub permanently severs the link in that case (`state cannot be changed. The repository that submitted this pull request has been deleted`). The fork has since been recreated, but a recreated fork gets a new internal ID, so reopening is not possible — a replacement PR was the only option. #43482 contains the same work rebased onto current `master`, including both fixes from @gabotorresruiz's review here (UUID/slug `dashboardId` matching, and preserving the identifier's own not-found error) and the added `lookup_dashboard_reference` coverage. The review history from this thread is summarized in the new PR's description so the context is not lost. @gabotorresruiz apologies for the churn — this needs a fresh approval on #43482 since the original one could not carry over. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
