rusackas opened a new pull request, #43496: URL: https://github.com/apache/superset/pull/43496
### SUMMARY `pyocient>=3.9.0` moved its `ST_*` geometry classes from private top-level names (`pyocient._STPoint`) to public ones under `pyocient.api` (`pyocient.api.STPoint`), and `STPolygon` gained a required `fullFlag` parameter. `test_ocient.py`'s GIS sanitization tests still imported the old private names, so the test module failed to even collect whenever the `ocient` extras were actually installed — invisible in standard CI since `pyocient` isn't a default test dependency, only surfacing when someone installs `apache-superset[ocient]` and runs the suite. This was found while verifying the SQLAlchemy 2.0 compatibility of the `ocient` extra, which #42542 flagged as "unverified" (discussion #40273). With the fixtures fixed, all 21 tests in the module pass under SQLAlchemy 2.0.52 — confirming the driver itself is fine under 2.0; the break was purely a pyocient-side rename unrelated to the SQLAlchemy bump. Updated the confidence note in `pyproject.toml` accordingly. ### TESTING INSTRUCTIONS ``` pip install "sqlalchemy-ocient>=3.0.0,<4" "pyocient>=3.9.0,<4" shapely geojson pytest tests/unit_tests/db_engine_specs/test_ocient.py -q ``` 21 passed, 0 failed. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
