bito-code-review[bot] commented on PR #43498:
URL: https://github.com/apache/superset/pull/43498#issuecomment-5405283529
<!-- Bito Reply -->
The flagged issue is correct. The current implementation spreads
`draggableConfig` after the `disabled` and `handle` props, allowing callers to
override these critical settings. To resolve this, you should spread the
`draggableConfig` first, ensuring that the required `disabled` and `handle`
props are applied last and cannot be overridden by the user-provided
configuration.
Here is the corrected implementation for
`superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx`:
```tsx
<Draggable
{...draggableConfig}
disabled={!draggable}
handle={draggable ? '.draggable-trigger' : undefined}
bounds={bounds ?? false}
onStart={(event, uiData) => onDragStart(event, uiData)}
```
I have checked the available comments, and there are no other actionable
suggestions in this PR. Would you like me to proceed with any other tasks?
**superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx**
```
<Draggable
{...draggableConfig}
disabled={!draggable}
handle={draggable ? '.draggable-trigger' : undefined}
bounds={bounds ?? false}
onStart={(event, uiData) => onDragStart(event, uiData)}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
