codeant-ai-for-open-source[bot] commented on code in PR #43498:
URL: https://github.com/apache/superset/pull/43498#discussion_r3849589901
##########
superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx:
##########
@@ -378,7 +365,8 @@ const CustomModal = ({
modalRender={modal =>
resizable || draggable ? (
<Draggable
Review Comment:
**Suggestion:** The later spread of `draggableConfig` allows callers to
override the enforced `disabled` and `handle` props. For example, `disabled:
false` can re-enable dragging on a non-draggable modal, while a custom `handle`
can make content draggable again or prevent the `.draggable-trigger` title from
working. Spread the configurable props first, then apply these invariant props
last, or explicitly omit them from `draggableConfig`. [api mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Non-draggable resizable modals can become draggable through
configuration.
- ⚠️ Custom handles can re-enable dragging from modal content.
- ⚠️ Consumers can unintentionally disable the title-bar drag handle.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=74565e76909d44cba5de2e6d54f14998&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=74565e76909d44cba5de2e6d54f14998&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx
**Line:** 367:375
**Comment:**
*Api Mismatch: The later spread of `draggableConfig` allows callers to
override the enforced `disabled` and `handle` props. For example, `disabled:
false` can re-enable dragging on a non-draggable modal, while a custom `handle`
can make content draggable again or prevent the `.draggable-trigger` title from
working. Spread the configurable props first, then apply these invariant props
last, or explicitly omit them from `draggableConfig`.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43498&comment_hash=91a1ce101afc6ab98890620df44e77cbf47efa5a2e4d73e2789a8a7a19e4e8e7&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43498&comment_hash=91a1ce101afc6ab98890620df44e77cbf47efa5a2e4d73e2789a8a7a19e4e8e7&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
