sadpandajoe commented on code in PR #43340:
URL: https://github.com/apache/superset/pull/43340#discussion_r3866909117
##########
docs/docs/using-superset/exporting-dashboard-data.mdx:
##########
@@ -47,12 +47,31 @@ Notes on the generated workbook:
This feature is **disabled by default**. It requires:
-1. **The `boto3` dependency.** It is not installed by default; install it with
- `pip install apache-superset[excel-export]`. Without it, exports fail and
the
- user receives a failure email.
-2. **An S3 bucket.** Set `EXCEL_EXPORT_S3_BUCKET`. Until it is set, the export
- endpoint returns `501` and the menu action surfaces a "not configured"
- message.
+1. **A storage bucket and backend.** Configure `EXPORT_STORAGE` with both
+ a `bucket` and a `backend` matching the bucket's provider — there is no
+ implicit default:
+
+ ```python
+ from superset.utils.s3 import S3ExportStorage # AWS S3
+ # from superset.utils.gcs import GCSExportStorage # Google Cloud Storage
+
+ EXPORT_STORAGE = {
+ "bucket": "my-export-bucket",
+ "backend": S3ExportStorage(),
+ }
+ ```
+
+ Until both are set, the export endpoint returns `501` and the menu action
+ surfaces a "not configured" message.
+2. **The backend's SDK dependency.** Not installed by default; install
+ `pip install apache-superset[excel-export]` (boto3) for `S3ExportStorage`,
+ or `pip install apache-superset[excel-export-gcs]` (google-cloud-storage)
+ for `GCSExportStorage`. Without it, exports fail and the user receives a
+ failure email. For `GCSExportStorage` with token-only Application Default
Review Comment:
The worker can upload successfully while this URL is later signed in the
Flask web process. With separate web and worker identities, documenting only
worker bucket write access leaves the web tier without the GCS signing/read
permissions and every ready download fails. Could this spell out the web-tier
requirements for `generate_download_url()` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
