sadpandajoe commented on code in PR #43340:
URL: https://github.com/apache/superset/pull/43340#discussion_r3867496789
##########
tests/integration_tests/dashboards/api_tests.py:
##########
@@ -3526,7 +3544,7 @@ def test_export_xlsx_admitted_with_can_export_only(
db.session.commit()
@pytest.mark.usefixtures("load_world_bank_dashboard_with_slices")
- @with_config({"EXCEL_EXPORT_S3_BUCKET": "exports"})
+ @with_config({"EXPORT_STORAGE": {"bucket": "exports", "backend":
MagicMock()}})
@patch("superset.dashboards.api.AcquireDistributedLock")
@patch("superset.dashboards.api.export_dashboard_excel")
def test_export_xlsx_admitted_without_email(self, mock_task, mock_acquire):
Review Comment:
This only exercises a logged-in user with an empty email, which still has
`g.user.id`; it cannot catch the guest crash or loss of guest-token claims this
change fixes. Could this use a real guest-token request and assert the
`user_id=None` and guest-token task kwargs, so the API-to-worker handoff is
covered?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
