codeant-ai-for-open-source[bot] commented on code in PR #43593: URL: https://github.com/apache/superset/pull/43593#discussion_r3873453923
########## docs/docs/using-superset/creating-your-first-dashboard.mdx: ########## @@ -406,6 +406,16 @@ ECharts option overrides bypass Superset's validation layer. Invalid option keys When the **Search Box** is visible in a Table chart, the **Download** action exports only the rows currently visible after the search filter is applied — not the full underlying dataset. This matches the visual output and is intentional. To export the full dataset regardless of search state, use the **Download as CSV** option from the chart's three-dot menu in the dashboard or from the Explore chart toolbar before applying a search filter. +### Exporting a Chart as an Image or PDF + +Alongside the raw-data export options (CSV, JSON, Excel), a chart's three-dot menu — in a dashboard or from the Explore chart toolbar — offers a few ways to export a visual snapshot of the chart: + +- **Export screenshot (jpeg)** — a single-click JPEG screenshot of the chart. +- **Export screenshot (png)** — opens a submenu with **Transparent background** and **Solid background** options. The solid option uses the current theme's background color. PNG produces a higher-quality image than the JPEG export. +- **Export as PDF** — downloads the chart as a PDF file. + +The dropdown menu is briefly hidden while the screenshot or PDF is being captured so it doesn't appear in the exported file. In Explore, these image and PDF options are available from both the **Export All Data** and **Export current view** submenus. Review Comment: **Suggestion:** The `Export current view` submenu is only rendered when `hasExportCurrentView` is true, so it is not available for every Explore chart. Qualify this instruction with the condition that the current-view export submenu is available for the chart. [incorrect condition logic] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ⚠️ Unsupported Explore charts lack the current-view submenu. - ⚠️ Users cannot follow the documented current-view export path. - ⚠️ Export instructions vary by chart plugin behavior. ``` </details> [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=50176394b12a411e8877aacdbc7f2fb4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=50176394b12a411e8877aacdbc7f2fb4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** docs/docs/using-superset/creating-your-first-dashboard.mdx **Line:** 417:417 **Comment:** *Incorrect Condition Logic: The `Export current view` submenu is only rendered when `hasExportCurrentView` is true, so it is not available for every Explore chart. Qualify this instruction with the condition that the current-view export submenu is available for the chart. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43593&comment_hash=b2a97dc9087ff2c4ed78174062e3908ded08c6e43b76331b8f0a637162b407a3&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43593&comment_hash=b2a97dc9087ff2c4ed78174062e3908ded08c6e43b76331b8f0a637162b407a3&reaction=dislike'>👎</a> ########## docs/docs/using-superset/creating-your-first-dashboard.mdx: ########## @@ -406,6 +406,16 @@ ECharts option overrides bypass Superset's validation layer. Invalid option keys When the **Search Box** is visible in a Table chart, the **Download** action exports only the rows currently visible after the search filter is applied — not the full underlying dataset. This matches the visual output and is intentional. To export the full dataset regardless of search state, use the **Download as CSV** option from the chart's three-dot menu in the dashboard or from the Explore chart toolbar before applying a search filter. +### Exporting a Chart as an Image or PDF + +Alongside the raw-data export options (CSV, JSON, Excel), a chart's three-dot menu — in a dashboard or from the Explore chart toolbar — offers a few ways to export a visual snapshot of the chart: Review Comment: **Suggestion:** The export actions are conditional: dashboard download actions are only included when the user has `supersetCanDownload`, and Explore image/PDF actions are disabled when `can_export_image` is false. Document the required download/image-export permissions or clarify that these options may be unavailable or disabled, otherwise users without access will be directed to menu items they cannot use. [api mismatch] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ⚠️ Dashboard export menu is hidden without download permission. - ⚠️ Explore image/PDF actions can be disabled by role permissions. - ⚠️ Users may not find or use documented export actions. ``` </details> [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=0f84bf1ecbc747ad88a7ac6a270f1dfb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=0f84bf1ecbc747ad88a7ac6a270f1dfb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** docs/docs/using-superset/creating-your-first-dashboard.mdx **Line:** 411:411 **Comment:** *Api Mismatch: The export actions are conditional: dashboard download actions are only included when the user has `supersetCanDownload`, and Explore image/PDF actions are disabled when `can_export_image` is false. Document the required download/image-export permissions or clarify that these options may be unavailable or disabled, otherwise users without access will be directed to menu items they cannot use. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43593&comment_hash=45f25a96309778284096dc7bfb000a778a1bfd4da447a161b049027cc2e62eaf&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43593&comment_hash=45f25a96309778284096dc7bfb000a778a1bfd4da447a161b049027cc2e62eaf&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
