bito-code-review[bot] commented on code in PR #43593: URL: https://github.com/apache/superset/pull/43593#discussion_r3875338383
########## docs/docs/using-superset/creating-your-first-dashboard.mdx: ########## @@ -406,6 +406,18 @@ ECharts option overrides bypass Superset's validation layer. Invalid option keys When the **Search Box** is visible in a Table chart, the **Download** action exports only the rows currently visible after the search filter is applied — not the full underlying dataset. This matches the visual output and is intentional. To export the full dataset regardless of search state, use the **Download as CSV** option from the chart's three-dot menu in the dashboard or from the Explore chart toolbar before applying a search filter. +### Exporting a Chart as an Image or PDF + +Alongside the raw-data export options (CSV, JSON, Excel), a chart's three-dot menu — in a dashboard or from the Explore chart toolbar — offers a few ways to export a visual snapshot of the chart: + +- **Export screenshot (jpeg)** — a single-click JPEG screenshot of the chart. +- **Export screenshot (png)** — opens a submenu with **Transparent background** and **Solid background** options. The solid option uses the current theme's background color. PNG produces a higher-quality image than the JPEG export. +- **Export as PDF** — downloads the chart as a PDF file. + +The dropdown menu is briefly hidden while the screenshot or PDF is being captured so it doesn't appear in the exported file. In Explore, these image and PDF options are available from the **Export All Data** submenu, and also from the **Export current view** submenu when the chart type supports current-view export. + +These menu items respect your permissions: the dashboard export menu only appears if you can download, and the image/PDF options are disabled if you lack image-export permission. Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Doc inaccurately claims menu hidden</b></div> <div id="fix"> The claim "the dashboard export menu only appears if you can download" is inaccurate. In `useHeaderActionsDropdownMenu.tsx` line 345, `menuItems.push(downloadMenuItem)` is unconditional — the submenu is always rendered. Only its children are filtered by `userCanExport` in `DownloadMenuItems/index.tsx` (lines 248-283). The image/PDF disable behavior is correct. ([BITO.md rule 10906](BITO.md)) </div> </div> <small><i>Code Review Run #521d7b</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
