codeant-ai-for-open-source[bot] commented on code in PR #43597:
URL: https://github.com/apache/superset/pull/43597#discussion_r3873484182
##########
docs/admin_docs/configuration/mcp-server.mdx:
##########
@@ -505,6 +505,8 @@ All MCP settings go in `superset_config.py`. Defaults are
defined in `superset/m
| `MCP_DEV_USERNAME` | -- | Superset username for development
mode (no auth)
|
| `MCP_RBAC_ENABLED` | `True` | Enforce Superset's role-based access
control on MCP tool calls. When `True`, each tool checks that the authenticated
user has the required FAB permission before executing. Disable only for testing
or trusted-network deployments. |
| `MCP_DISABLED_TOOLS` | `set()` | Set of tool names to remove from the
MCP server at startup. Disabled tools are never advertised to AI clients during
tool discovery. Useful when a custom extension tool should replace a built-in
Superset tool. See [Disabling built-in tools](#disabling-built-in-tools). |
+| `MCP_DISABLED_CHART_PLUGINS` | `frozenset()` | Set of chart type plugin
names (e.g. `"handlebars"`) to hide from `generate_chart` and related chart
tools. See [Disabling chart type plugins](#disabling-chart-type-plugins). |
Review Comment:
**Suggestion:** The scope is broader than the implementation:
`get_chart_type_schema` uses its own static adapter list and does not consult
the registry filter, so a disabled chart type remains discoverable through that
tool. Do not promise that the settings hide plugins from related chart tools
unless those tools apply the same filter, or explicitly document the tools
affected. [api mismatch]
<details>
<summary><b>Severity Level:</b> Minor ๐งน</summary>
```mdx
- โ ๏ธ Schema discovery exposes disabled chart types.
- โ ๏ธ MCP clients may attempt unsupported chart generation calls.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=a01f12286d844d61a50b8c79948965f5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=a01f12286d844d61a50b8c79948965f5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docs/admin_docs/configuration/mcp-server.mdx
**Line:** 508:508
**Comment:**
*Api Mismatch: The scope is broader than the implementation:
`get_chart_type_schema` uses its own static adapter list and does not consult
the registry filter, so a disabled chart type remains discoverable through that
tool. Do not promise that the settings hide plugins from related chart tools
unless those tools apply the same filter, or explicitly document the tools
affected.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43597&comment_hash=ec10a144b25f8405b210de05bdeb2d5c8555f9bf123cfd7c532543001f21eba0&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43597&comment_hash=ec10a144b25f8405b210de05bdeb2d5c8555f9bf123cfd7c532543001f21eba0&reaction=dislike'>๐</a>
##########
docs/admin_docs/configuration/mcp-server.mdx:
##########
@@ -893,6 +895,39 @@ MCP_DISABLED_TOOLS =
{"extensions.myorg.myextension.some_tool"}
Specifying a tool name that does not exist logs a warning at startup and is
otherwise ignored โ it will not prevent the server from starting.
:::
+## Disabling chart type plugins
+
+The `generate_chart` tool dispatches per chart type (`xy`, `table`, `pie`,
`pivot_table`, `mixed_timeseries`, `handlebars`, `big_number`) to a registered
chart type plugin. Two settings let operators enable or disable individual
chart type plugins at runtime, without a code deploy.
Review Comment:
**Suggestion:** The documented chart type list is incomplete: the
implementation also supports `histogram`, `box_plot`, and `waterfall`.
Operators following this list may omit supported plugins from their filtering
configuration or incorrectly conclude that these chart types are unavailable.
Include all supported chart types, or link to the authoritative registry
instead of maintaining a separate list. [api mismatch]
<details>
<summary><b>Severity Level:</b> Major โ ๏ธ</summary>
```mdx
- โ ๏ธ Operators receive an incomplete plugin inventory.
- โ ๏ธ Omitted chart types may escape intended filtering configuration.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=d1ed9c05e24644909c04fdb9017e11eb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=d1ed9c05e24644909c04fdb9017e11eb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docs/admin_docs/configuration/mcp-server.mdx
**Line:** 900:900
**Comment:**
*Api Mismatch: The documented chart type list is incomplete: the
implementation also supports `histogram`, `box_plot`, and `waterfall`.
Operators following this list may omit supported plugins from their filtering
configuration or incorrectly conclude that these chart types are unavailable.
Include all supported chart types, or link to the authoritative registry
instead of maintaining a separate list.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43597&comment_hash=b422d5b88c15dbd29bdd30dcda1e446001c5ca619a62ed2dab0942c7744d825f&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43597&comment_hash=b422d5b88c15dbd29bdd30dcda1e446001c5ca619a62ed2dab0942c7744d825f&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
