rusackas commented on code in PR #43597:
URL: https://github.com/apache/superset/pull/43597#discussion_r3873817780
##########
docs/admin_docs/configuration/mcp-server.mdx:
##########
@@ -505,6 +505,8 @@ All MCP settings go in `superset_config.py`. Defaults are
defined in `superset/m
| `MCP_DEV_USERNAME` | -- | Superset username for development
mode (no auth)
|
| `MCP_RBAC_ENABLED` | `True` | Enforce Superset's role-based access
control on MCP tool calls. When `True`, each tool checks that the authenticated
user has the required FAB permission before executing. Disable only for testing
or trusted-network deployments. |
| `MCP_DISABLED_TOOLS` | `set()` | Set of tool names to remove from the
MCP server at startup. Disabled tools are never advertised to AI clients during
tool discovery. Useful when a custom extension tool should replace a built-in
Superset tool. See [Disabling built-in tools](#disabling-built-in-tools). |
+| `MCP_DISABLED_CHART_PLUGINS` | `frozenset()` | Set of chart type plugin
names (e.g. `"handlebars"`) to hide from `generate_chart` and related chart
tools. See [Disabling chart type plugins](#disabling-chart-type-plugins). |
Review Comment:
Fixed — the row for `MCP_DISABLED_CHART_PLUGINS` now says it scopes to
`generate_chart` and calls out that `get_chart_type_schema` uses its own static
schema map, so a disabled type stays queryable there.
##########
docs/admin_docs/configuration/mcp-server.mdx:
##########
@@ -893,6 +895,39 @@ MCP_DISABLED_TOOLS =
{"extensions.myorg.myextension.some_tool"}
Specifying a tool name that does not exist logs a warning at startup and is
otherwise ignored — it will not prevent the server from starting.
:::
+## Disabling chart type plugins
+
+The `generate_chart` tool dispatches per chart type (`xy`, `table`, `pie`,
`pivot_table`, `mixed_timeseries`, `handlebars`, `big_number`) to a registered
chart type plugin. Two settings let operators enable or disable individual
chart type plugins at runtime, without a code deploy.
Review Comment:
Fixed — added `histogram`, `box_plot`, and `waterfall` to the dispatch list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
