bito-code-review[bot] commented on PR #43636: URL: https://github.com/apache/superset/pull/43636#issuecomment-5448271435
<!-- Bito Reply --> The flagged issue is correct. The documentation incorrectly implies that all totals are computed by the database, whereas additive metrics like `SUM` and `COUNT` are typically reduced client-side from the leaf query results. To resolve this, the note should be updated to clarify that while non-additive metrics use database grouping sets, additive metrics are computed client-side. Would you like me to implement this correction for you? I can also check the rest of the PR for other comments if you would like me to address those as well. **docs/docs/using-superset/exploring-data.mdx** ``` :::note Row and column totals/subtotals for the Pivot Table are computed by the database for non-additive metrics (e.g., `COUNT_DISTINCT`, `AVG`, percentiles), while additive metrics (e.g., `SUM`, `COUNT`) are computed via client-side reduction of the leaf query. This ensures totals are accurate for all metric types. ::: ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
