bito-code-review[bot] commented on code in PR #43636: URL: https://github.com/apache/superset/pull/43636#discussion_r3878267698
########## docs/docs/using-superset/exploring-data.mdx: ########## @@ -151,6 +151,16 @@ see some data! You should see months in the rows and Department and Travel Class in the columns. Publish this chart to your existing Tutorial Dashboard you created earlier. +:::note +Row and column totals/subtotals for the Pivot Table are computed by the database, at the same +granularity as the total itself, rather than by summing the already-aggregated cells shown in the +table. This means totals are correct for non-additive metrics too, such as ratios +(`SUM(a)/SUM(b)`), `COUNT_DISTINCT`, `AVG`, and percentiles, not just additive ones like `SUM` or +`COUNT`. Because of this, there's no separate "Aggregation function" control for totals: a total +always reflects the metric's own definition evaluated at that total's level. The Table chart's +**Show summary** row behaves the same way for percentage metrics. Review Comment: <!-- Bito Reply --> The update correctly addresses the reviewer's concern by removing the inaccurate claim about the Table chart's behavior and clarifying the distinction between the Pivot Table and the Table chart's summary aggregation capabilities. This change improves the technical accuracy of the documentation. **docs/docs/using-superset/exploring-data.mdx** ``` :::note Row and column totals/subtotals for the Pivot Table are computed by the database, at the same granularity as the total itself, rather than by summing the already-aggregated cells shown in the table. This means totals are correct for non-additive metrics too, such as ratios (`SUM(a)/SUM(b)`), `COUNT_DISTINCT`, `AVG`, and percentiles, not just additive ones like `SUM` or `COUNT`. Because of this, there's no separate "Aggregation function" control for totals: a total always reflects the metric's own definition evaluated at that total's level. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
