codeant-ai-for-open-source[bot] commented on code in PR #43639: URL: https://github.com/apache/superset/pull/43639#discussion_r3877952119
########## docs/admin_docs/configuration/theming.mdx: ########## @@ -138,6 +138,18 @@ The existing `APP_NAME` Python config key continues to work for backward compati Email and alert/report notification subjects are driven by backend settings such as `EMAIL_REPORTS_SUBJECT_PREFIX` and `APP_NAME`, not by this theme token. +To hide the logo image in the navbar entirely (for example, when a text-only +brand is preferred), set `HIDE_NAVBAR_LOGO` in `superset_config.py`: + +```python +# Hide the logo image in the navbar. The brand text (brandAppName / APP_NAME) +# still renders if configured. Defaults to False. Review Comment: **Suggestion:** The documentation says the configured brand text still renders when `HIDE_NAVBAR_LOGO` is enabled, but the navbar implementation suppresses both the logo and `brand.text` whenever `brand.hide_logo` is true. Users following this example will not get a text-only navbar; update the explanation to state that the entire brand area is hidden, or document the separate configuration needed for text-only branding. [api mismatch] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ❌ Text-only navbar branding does not render as documented. - ⚠️ Administrators may hide all navbar branding unintentionally. ``` </details> [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=65ac41e19b06488ab132fbecaeef0c71&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=65ac41e19b06488ab132fbecaeef0c71&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** docs/admin_docs/configuration/theming.mdx **Line:** 145:146 **Comment:** *Api Mismatch: The documentation says the configured brand text still renders when `HIDE_NAVBAR_LOGO` is enabled, but the navbar implementation suppresses both the logo and `brand.text` whenever `brand.hide_logo` is true. Users following this example will not get a text-only navbar; update the explanation to state that the entire brand area is hidden, or document the separate configuration needed for text-only branding. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43639&comment_hash=d3ccb3b813fd3055a7738e5e81dc88a36cd05367e90abb89dd0c5f73f9c6fabf&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43639&comment_hash=d3ccb3b813fd3055a7738e5e81dc88a36cd05367e90abb89dd0c5f73f9c6fabf&reaction=dislike'>👎</a> ########## docs/admin_docs/configuration/theming.mdx: ########## @@ -454,6 +466,115 @@ THEME_DEFAULT = { This feature provides powerful theming capabilities while maintaining the flexibility of ECharts' extensive configuration options. +## Component Sizing & Style Tokens + +:::note +Available since Superset 6.1 +::: + +Beyond colors and fonts, a handful of Superset-specific tokens let you tune the +sizing, radius, and outline behavior of individual UI components. All of these +tokens are optional — omit them and components fall back to their existing +defaults, so applying them is a zero-visual-change operation until you opt in. + +### Button & DropdownButton Sizing + +```python +THEME_DEFAULT = { + "token": { + # ... other tokens + "buttonControlHeight": 32, # default button height, in px + "buttonControlHeightSM": 30, # small/dropdown button height, in px + "buttonControlHeightXS": 24, # xsmall button height, in px + "buttonPaddingInline": 16, # horizontal padding, in px + "buttonPaddingInlineSM": 12, # horizontal padding for small buttons, in px + "buttonFontSize": 14, + "buttonBorderRadius": 4, + } +} +``` + +`buttonControlHeight` and `buttonBorderRadius` also drive the sizing of the +menu-trigger button used by `PageHeaderWithActions`, so a single pair of tokens +keeps page-header icon buttons visually consistent with regular buttons. + +For one-off overrides that shouldn't apply to every button in the app, pass a +`styleConfig` prop directly to `Button` or `DropdownButton` instead of setting +a theme token: + +```tsx +<Button + styleConfig={{ + controlHeight: 40, + paddingInline: 20, + fontSize: 16, + fontWeight: 700, + borderRadius: 8, + ctaMinWidth: 120, + ctaMinHeight: 40, + iconGap: 8, + }} +> + Click me +</Button> + +<DropdownButton + styleConfig={{ + controlHeight: 32, + fontSize: 14, + fontWeight: 500, + boxShadow: '0 2px 4px rgba(0,0,0,0.1)', + }} + menu={menuProps} +> + Options +</DropdownButton> +``` + +`styleConfig` values take precedence over the equivalent theme tokens, which in +turn take precedence over the built-in defaults. + +### Label Border Radius + +```python +THEME_DEFAULT = { + "token": { + "labelBorderRadius": 4, # defaults to 8px + } +} +``` + +### Select Option Outline + +By default, hovering or navigating to an option in a `Select` dropdown draws a +2px outline in `colorPrimary`. Set `selectOptionActiveOutline` to `False` for a +more subtle hover style with no outline: + +```python +THEME_DEFAULT = { + "token": { + "selectOptionActiveOutline": False, + } +} +``` + +### Dashboard Tile Appearance + +Chart tiles on a dashboard (not text/markdown tiles) can be restyled via +`dashboardTile*` tokens. All fall back to the existing look — a +`colorBgContainer` background with no border and a hairline `box-shadow`: Review Comment: **Suggestion:** The stated fallback is inaccurate: dashboard chart tiles default to a `1px solid colorBorder` border, not no border. Also, the default hairline box shadow is applied only during the fade-out state rather than being present on every tile. Correct the fallback description so administrators understand the result of omitting these tokens. [docstring mismatch] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ⚠️ Dashboard styling guidance misstates the default border. - ⚠️ Administrators may expect shadows on every chart tile. ``` </details> [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=e94baa27a1b24757aefceda4d131332a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=e94baa27a1b24757aefceda4d131332a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** docs/admin_docs/configuration/theming.mdx **Line:** 563:565 **Comment:** *Docstring Mismatch: The stated fallback is inaccurate: dashboard chart tiles default to a `1px solid colorBorder` border, not no border. Also, the default hairline box shadow is applied only during the fade-out state rather than being present on every tile. Correct the fallback description so administrators understand the result of omitting these tokens. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43639&comment_hash=35ae3bbca9c314e85f3b0bd07a4006972c1dfd90f083b0b2721df4a51fb43fea&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43639&comment_hash=35ae3bbca9c314e85f3b0bd07a4006972c1dfd90f083b0b2721df4a51fb43fea&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
