sadpandajoe commented on code in PR #43639:
URL: https://github.com/apache/superset/pull/43639#discussion_r3886432244
##########
docs/admin_docs/configuration/theming.mdx:
##########
@@ -454,6 +466,117 @@ THEME_DEFAULT = {
This feature provides powerful theming capabilities while maintaining the
flexibility of ECharts' extensive configuration options.
+## Component Sizing & Style Tokens
+
+:::note
+Available since Superset 6.1
+:::
+
+Beyond colors and fonts, a handful of Superset-specific tokens let you tune the
+sizing, radius, and outline behavior of individual UI components. All of these
+tokens are optional — omit them and components fall back to their existing
+defaults, so applying them is a zero-visual-change operation until you opt in.
+
+### Button & DropdownButton Sizing
+
+```python
+THEME_DEFAULT = {
+ "token": {
+ # ... other tokens
+ "buttonControlHeight": 32, # default button height, in px
+ "buttonControlHeightSM": 30, # small/dropdown button height, in px
+ "buttonControlHeightXS": 24, # xsmall button height, in px
Review Comment:
The fallback values in this example do not match `Button`: an unconfigured
xsmall button is 22px, and the default/small horizontal padding is 18px/10px
(`Button/index.tsx`). Labeling 24px, 16px, and 12px as defaults leads theme
authors to introduce unintended sizing overrides. Could this use the actual
fallbacks or label these as example overrides?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
