codeant-ai-for-open-source[bot] commented on code in PR #39657:
URL: https://github.com/apache/superset/pull/39657#discussion_r3880069723
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/GroupByFilterCard.tsx:
##########
@@ -608,7 +608,7 @@ const GroupByFilterCard: FC<GroupByFilterCardProps> = ({
.includes(input.toLowerCase())
}
sortComparator={sortComparator}
- getPopupContainer={triggerNode => triggerNode.parentNode}
+ getPopupContainer={() => document.body}
Review Comment:
**Suggestion:** Mounting the dropdown under `document.body` removes it from
the `HorizontalFormItem` styled wrapper, so the wrapper-scoped
`.ant-select-dropdown` rules no longer match. The horizontal group-by dropdown
will lose its required 200–400px width constraints; keep the popup under the
styled ancestor or move these width rules to a global/class-based selector that
also applies to portaled dropdowns. [css layout issue]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ⚠️ Horizontal native group-by dropdown loses its 200–400px width
constraints.
- ⚠️ Column option menus may become narrower or wider than intended.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=2e6920b3ba3f4b6b9d9bb4698501e54d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=2e6920b3ba3f4b6b9d9bb4698501e54d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/GroupByFilterCard.tsx
**Line:** 611:611
**Comment:**
*Css Layout Issue: Mounting the dropdown under `document.body` removes
it from the `HorizontalFormItem` styled wrapper, so the wrapper-scoped
`.ant-select-dropdown` rules no longer match. The horizontal group-by dropdown
will lose its required 200–400px width constraints; keep the popup under the
styled ancestor or move these width rules to a global/class-based selector that
also applies to portaled dropdowns.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39657&comment_hash=4af54a08fa6104caa8eb3a5c7cecd4f1c06be5a915e75805a5a7c7c33ab691e7&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39657&comment_hash=4af54a08fa6104caa8eb3a5c7cecd4f1c06be5a915e75805a5a7c7c33ab691e7&reaction=dislike'>👎</a>
##########
superset-frontend/src/explore/components/controls/ColorSchemeControl/index.tsx:
##########
@@ -321,7 +321,7 @@ const ColorSchemeControl = ({
placeholder={t('Select scheme')}
value={currentScheme}
showSearch
- getPopupContainer={triggerNode => triggerNode.parentNode}
+ getPopupContainer={() => document.body}
Review Comment:
**Suggestion:** The grouped-option styling is defined in the `Select`
component's scoped `css` prop and therefore only matches dropdown elements that
remain descendants of that component. Rendering the dropdown in `document.body`
causes `.ant-select-item-option-grouped` and the grouped-item rules to stop
matching, so grouped color-scheme options lose their intended padding and font
styling. Move these rules to a popup class/global selector or use a container
that preserves the styling scope. [css layout issue]
<details>
<summary><b>Severity Level:</b> Minor 🧹</summary>
```mdx
- ⚠️ Explore color-scheme grouped headers lose custom padding.
- ⚠️ Grouped color-scheme options lose intended indentation.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=6c63a2b5a32148e887e9b81d61c54975&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=6c63a2b5a32148e887e9b81d61c54975&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/explore/components/controls/ColorSchemeControl/index.tsx
**Line:** 324:324
**Comment:**
*Css Layout Issue: The grouped-option styling is defined in the
`Select` component's scoped `css` prop and therefore only matches dropdown
elements that remain descendants of that component. Rendering the dropdown in
`document.body` causes `.ant-select-item-option-grouped` and the grouped-item
rules to stop matching, so grouped color-scheme options lose their intended
padding and font styling. Move these rules to a popup class/global selector or
use a container that preserves the styling scope.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39657&comment_hash=47037655dfb78742f35fb403e445e53a9530058824da2c8d9cf8b0a212afa4f0&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39657&comment_hash=47037655dfb78742f35fb403e445e53a9530058824da2c8d9cf8b0a212afa4f0&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
