7487 commented on PR #39657:
URL: https://github.com/apache/superset/pull/39657#issuecomment-5473175076
Merged latest master to resolve the conflicts (merge commit, no force-push).
The diff against master is unchanged in scope — same 11 files.
Re bito's UserListModal note: both the roles and groups Selects in that
modal now use `getPopupContainer={() => document.body}`, so the sibling
inconsistency is already resolved on this branch.
Verified locally against the merged branch:
- `oxfmt --check` and `oxlint` clean on all touched files
- jest green on the related suites: `antdDomContract.test.tsx`,
`Select.test.tsx`, `AsyncSelect.test.tsx`, `DateFilterControl/tests`,
`RoleFormItems.test.tsx`, `ColorSchemeControl`, and `FilterBar/FilterControls`
(300+ tests passing)
The previous CI run failed across the board at checkout because of the
conflicted merge ref, so those failures weren't test-related. Should be good
for a fresh CI run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
