mikebridge commented on PR #43632: URL: https://github.com/apache/superset/pull/43632#issuecomment-5457215337
Fair correction on the `toHaveStyle` assertion, @aminghadersohi — it does discriminate (revert-only-`DateFilterLabel.tsx` fails it), so it isn't vacuous; my comment overweighted the jsdom `min()` serialisation quirk. The limitation is the one you name: declaration-level, so it can't see the layout regression. Keep the assertions; the layout claim wants a Playwright spec. Thanks for running the replica independently — same numbers, same branch-specific conclusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
