fitzee commented on PR #43632: URL: https://github.com/apache/superset/pull/43632#issuecomment-5490758670
@aminghadersohi @mikebridge Thank you for the independent replicas and the correction on the style assertion. I addressed the actionable review at `d151f63eee` (implementation changes are in `6f3a0c8947`): - **Blocker — height regression:** removed the height leg in full. The 500px body floor, `70vh` sidebar cap plus sc-101839 rationale, and explicit tab `contentHeight` are restored. There is no indefinite percentage-height chain left in the PR. - **Nested popup containing block:** changed the cap from `%` to `100vw`, and asserted the result in both body-mounted and **More filters**-mounted modes. - **Overflow behavior:** added a probe test at the underlying Superset `Popover`; opening `DateFilterLabel` must pass `SHIFT_INTO_VIEWPORT`. This tests the resolved behavioral prop rather than only the CSS declaration. Dropping the old local `false` override reuses `ControlPopover`'s tested standard flip/shift path; it does not restore the removed modal-overlay styling from the earlier z-index fix. - **Width cleanup:** replaced the minimum/media-query split with an 880px target plus a containing-block `max-width`, renamed the constant, and fixed the old invalid unitless normal-width declaration. - **Scope/evidence:** the PR description is rewritten to stop claiming a host-occlusion or modal-height repair. The customer host page and a runnable local Superset server are unavailable here, and CSS inside the iframe cannot observe occlusion introduced outside it. Because the layout-changing height leg was removed, I did not add a Playwright test for that reverted behavior; focused component coverage protects the remaining declaration and Popover-prop enforcement points. Customer-host validation remains called out as a residual requirement. Validation: ```text 3 Jest suites passed, 17 tests passed staged pre-commit: all applicable hooks passed ``` I replied on and resolved all five inline threads. The deployment, Codecov, and Bito bot comments were informational/green and requested no code changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
