rusackas commented on code in PR #43662:
URL: https://github.com/apache/superset/pull/43662#discussion_r3886794029
##########
.github/workflows/testcontainers.yml:
##########
@@ -110,6 +117,16 @@ jobs:
if: matrix.dialect == 'db2'
run: uv pip install --system -e .[db2]
- name: Run testcontainers db_engine_specs tests (${{ matrix.dialect }})
+ # A job-level `if:` can't reference `matrix` (only github/inputs/
+ # needs/vars are available there), so the nightly_only skip has to
+ # live on the step instead. A dialect without `nightly_only` set
+ # evaluates the left side true (unset is null, and `null != true`
+ # is true) and always runs; one WITH it set only runs on the cron
+ # or a manual dispatch, never on pull_request.
+ if: >-
Review Comment:
Good catch, fixed — added a `compute-matrix` job that filters `nightly_only`
dialects out of the matrix before the `testcontainers` job is even created, so
a PR run skips checkout/setup/driver-install for them too, not just the test
step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
