bito-code-review[bot] commented on PR #43662:
URL: https://github.com/apache/superset/pull/43662#issuecomment-5462343056
<!-- Bito Reply -->
Yes, you are correct. Because the `if` condition is applied at the step
level, the preceding steps—such as checkout, environment setup, and the `uv pip
install` for the DB2 dialect—still execute for every PR, even if the test step
itself is skipped. To prevent these steps from running, the `if` condition must
be moved to the job level. However, as noted in the workflow comments,
job-level `if` conditions cannot directly reference `matrix` variables. To
achieve this, you would need to define the `nightly_only` logic as a job output
or use a separate job definition for nightly-only dialects that excludes them
from the standard PR matrix.
**.github/workflows/testcontainers.yml**
```
if: >-
matrix.nightly_only != true ||
github.event_name == 'schedule' ||
github.event_name == 'workflow_dispatch'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
