codeant-ai-for-open-source[bot] commented on code in PR #43689:
URL: https://github.com/apache/superset/pull/43689#discussion_r3887488833
##########
superset-websocket/src/index.ts:
##########
@@ -381,13 +387,15 @@ function isTaskStatusRedisPayload(
const candidate = payload as {
task_id?: unknown;
status?: unknown;
- subscribers?: unknown;
+ channels?: unknown;
};
return (
typeof candidate.task_id === 'string' &&
typeof candidate.status === 'string' &&
- Array.isArray(candidate.subscribers) &&
- candidate.subscribers.every(isTaskStatusSubscriber)
+ Array.isArray(candidate.channels) &&
+ candidate.channels.every(
+ channel => typeof channel === 'string' && channel.length > 0,
+ )
);
Review Comment:
**Suggestion:** Requiring `channels` makes the websocket server reject the
previous `{task_id, status}` task-status message format. During a rolling
deployment, or when another publisher still emits the legacy shape, every
status event is logged as invalid and dropped instead of being delivered at
principal grain as before. Accept the legacy shape with principal-grain
routing, or coordinate an atomic producer/consumer protocol migration. [api
mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Async chart task-status events drop during rolling upgrades.
- ⚠️ Browsers rely on polling backstop for completion updates.
- ⚠️ Mixed worker/websocket versions lose realtime delivery.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=626530358bf944f1af139ba911397e3e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=626530358bf944f1af139ba911397e3e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-websocket/src/index.ts
**Line:** 395:399
**Comment:**
*Api Mismatch: Requiring `channels` makes the websocket server reject
the previous `{task_id, status}` task-status message format. During a rolling
deployment, or when another publisher still emits the legacy shape, every
status event is logged as invalid and dropped instead of being delivered at
principal grain as before. Accept the legacy shape with principal-grain
routing, or coordinate an atomic producer/consumer protocol migration.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43689&comment_hash=cdb0715484c0b6dcaecb653bda71b6e5d56cd29dda765fca553b540efc134d0f&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43689&comment_hash=cdb0715484c0b6dcaecb653bda71b6e5d56cd29dda765fca553b540efc134d0f&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
