codeant-ai-for-open-source[bot] commented on code in PR #43689:
URL: https://github.com/apache/superset/pull/43689#discussion_r3888521745
##########
superset-websocket/src/index.ts:
##########
@@ -381,13 +387,15 @@ function isTaskStatusRedisPayload(
const candidate = payload as {
task_id?: unknown;
status?: unknown;
- subscribers?: unknown;
+ channels?: unknown;
};
return (
typeof candidate.task_id === 'string' &&
typeof candidate.status === 'string' &&
- Array.isArray(candidate.subscribers) &&
- candidate.subscribers.every(isTaskStatusSubscriber)
+ Array.isArray(candidate.channels) &&
+ candidate.channels.every(
+ channel => typeof channel === 'string' && channel.length > 0,
+ )
);
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not require transitional dual-shape acceptance for internal Redis wire
contracts when the producer and consumer are introduced and deployed together
as part of the same atomic feature rollout; treat the new payload shape as the
sole supported contract.
**Applied to:**
- `superset-websocket/**`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
