FrancescoCastaldi commented on PR #43585: URL: https://github.com/apache/superset/pull/43585#issuecomment-5470949988
Thanks @rusackas! I fixed the import ordering in superset/charts/schemas.py so that PROPHET_TIME_GRAIN_MAP is imported after superset.utils.core to make ruff / pre-commit happy, and force-pushed the branch. Regarding ChartDataProphetOptionsSchema not being wired into ChartDataPostProcessingOperationSchema.options, totally agree: dynamic per-operation options validation would require a broader polymorphic schema refactor. Updated the commit and kept the schema accuracy and dynamic ime_grain_sqla fixes intact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
