rusackas commented on code in PR #43585:
URL: https://github.com/apache/superset/pull/43585#discussion_r3890453992
##########
superset/charts/schemas.py:
##########
@@ -757,7 +758,7 @@ class
ChartDataProphetOptionsSchema(ChartDataPostProcessingOperationOptionsSchem
"[ISO 8601](https://en.wikipedia.org/wiki/ISO_8601#Durations)
durations.",
"example": "P1D",
},
- validate=validate.OneOf(choices=get_time_grain_choices()),
+ validate=validate.OneOf(choices=tuple(PROPHET_TIME_GRAIN_MAP.keys())),
Review Comment:
The import fix landed, thanks! The description hasn't changed though (last
edit predates this thread)... it still frames this as changing what an API
caller sees, and the "Fixes #43356" would close the issue on merge even though
caller-visible behavior stays the same. If you can reword the SUMMARY to frame
this as a schema-accuracy fix plus the stale time-grain-choices fix (and maybe
soften Fixes to a plain reference), I think we're good to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
