kokhlo commented on PR #43682: URL: https://github.com/apache/superset/pull/43682#issuecomment-5470986527
Please go ahead — the gap is yours. One pointer from digging into it while reviewing this PR: `pivot_table` has no index-side dropna flag, so the usual approach is filling NULL index keys before the pivot (the way `_restore_dropped_metric_columns` already handles NULL preservation structurally), and the regression test should assert the NULL group survives the full aggregate → pivot chain, not just aggregate alone. Happy to review when the PR is up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
