endimonan commented on code in PR #43756:
URL: https://github.com/apache/superset/pull/43756#discussion_r3907190309
##########
superset-frontend/plugins/plugin-chart-table/src/DataTable/components/GlobalFilter.tsx:
##########
@@ -87,10 +94,14 @@ export default (memo as <T>(fn: T) => T)(function
GlobalFilter<
}: GlobalFilterProps<D>) {
const count = serverPagination ? rowCount : preGlobalFilteredRows.length;
const inputRef = useRef<InputRef>(null);
+ const isComposingRef = useRef(false);
const [value, setValue] = useAsyncState(
filterValue,
(newValue: string) => {
+ if (isComposingRef.current) {
Review Comment:
I would say this behavior is intentional: the guard follows the browser’s
composition lifecycle regardless of language or keyboard. On Gboard, the input
value still updates immediately, while filtering waits until the keyboard
commits the word. I don’t think we should special-case CJK or Android here. But
if you think this should be addressed, let me know
@amaannawab923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
