endimonan commented on code in PR #43756:
URL: https://github.com/apache/superset/pull/43756#discussion_r3934680059
##########
superset-frontend/plugins/plugin-chart-table/src/DataTable/components/GlobalFilter.tsx:
##########
@@ -116,6 +128,16 @@ export default (memo as <T>(fn: T) => T)(function
GlobalFilter<
const handleBlur = () => {
isSearchFocused.set(id, false);
+ isComposingRef.current = false;
Review Comment:
Ah, I see what you mean now. I’ll update handleBlur to replay the current
value only when it interrupts an active composition, and add a test covering a
delayed blur without compositionend. Let me know if it makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]