codecov[bot] commented on PR #43769: URL: https://github.com/apache/superset/pull/43769#issuecomment-5512841345
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/43769?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `41.23223%` with `124 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 75.01%. Comparing base ([`4395640`](https://app.codecov.io/gh/apache/superset/commit/439564041f54cafbc17f2f995c682c65b8bbbaab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`dde47c2`](https://app.codecov.io/gh/apache/superset/commit/dde47c2cef2b08ec439831ea1236f8920aad1ae4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 16 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/43769?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rset-frontend/src/embedded/embeddedChart/index.tsx](https://app.codecov.io/gh/apache/superset/pull/43769?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fembedded%2FembeddedChart%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2VtYmVkZGVkL2VtYmVkZGVkQ2hhcnQvaW5kZXgudHN4) | 6.97% | [40 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43769?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/charts/api.py](https://app.codecov.io/gh/apache/superset/pull/43769?src=pr&el=tree&filepath=superset%2Fcharts%2Fapi.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | 50.94% | [26 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43769?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ntend/src/embedded/embeddedChart/useExploreData.ts](https://app.codecov.io/gh/apache/superset/pull/43769?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fembedded%2FembeddedChart%2FuseExploreData.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2VtYmVkZGVkL2VtYmVkZGVkQ2hhcnQvdXNlRXhwbG9yZURhdGEudHM=) | 0.00% | [19 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43769?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/embedded/view.py](https://app.codecov.io/gh/apache/superset/pull/43769?src=pr&el=tree&filepath=superset%2Fembedded%2Fview.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZW1iZWRkZWQvdmlldy5weQ==) | 8.33% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43769?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/security/manager.py](https://app.codecov.io/gh/apache/superset/pull/43769?src=pr&el=tree&filepath=superset%2Fsecurity%2Fmanager.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | 28.57% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/superset/pull/43769?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...dashboard/components/SliceHeaderControls/index.tsx](https://app.codecov.io/gh/apache/superset/pull/43769?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fdashboard%2Fcomponents%2FSliceHeaderControls%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMvaW5kZXgudHN4) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43769?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/daos/chart.py](https://app.codecov.io/gh/apache/superset/pull/43769?src=pr&el=tree&filepath=superset%2Fdaos%2Fchart.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGFvcy9jaGFydC5weQ==) | 66.66% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43769?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset-frontend/src/embedded/index.tsx](https://app.codecov.io/gh/apache/superset/pull/43769?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fembedded%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2VtYmVkZGVkL2luZGV4LnRzeA==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43769?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...d/src/dashboard/components/EmbeddedModal/index.tsx](https://app.codecov.io/gh/apache/superset/pull/43769?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fdashboard%2Fcomponents%2FEmbeddedModal%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0VtYmVkZGVkTW9kYWwvaW5kZXgudHN4) | 75.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43769?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...tend/src/embedded/embeddedChart/hydrateEmbedded.ts](https://app.codecov.io/gh/apache/superset/pull/43769?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fembedded%2FembeddedChart%2FhydrateEmbedded.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2VtYmVkZGVkL2VtYmVkZGVkQ2hhcnQvaHlkcmF0ZUVtYmVkZGVkLnRz) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43769?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [1 more](https://app.codecov.io/gh/apache/superset/pull/43769?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #43769 +/- ## ========================================== - Coverage 79.29% 75.01% -4.29% ========================================== Files 2889 2893 +4 Lines 166762 166987 +225 Branches 38604 38643 +39 ========================================== - Hits 132241 125258 -6983 - Misses 32027 39179 +7152 - Partials 2494 2550 +56 ``` | [Flag](https://app.codecov.io/gh/apache/superset/pull/43769/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hive](https://app.codecov.io/gh/apache/superset/pull/43769/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.83% <52.54%> (+<0.01%)` | :arrow_up: | | [javascript](https://app.codecov.io/gh/apache/superset/pull/43769/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.72% <22.58%> (-0.06%)` | :arrow_down: | | [mysql](https://app.codecov.io/gh/apache/superset/pull/43769/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [postgres](https://app.codecov.io/gh/apache/superset/pull/43769/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [presto](https://app.codecov.io/gh/apache/superset/pull/43769/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.73% <53.38%> (+<0.01%)` | :arrow_up: | | [python](https://app.codecov.io/gh/apache/superset/pull/43769/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.26% <55.93%> (-8.55%)` | :arrow_down: | | [sqlite](https://app.codecov.io/gh/apache/superset/pull/43769/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unit](https://app.codecov.io/gh/apache/superset/pull/43769/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.26% <55.93%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. </details> [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/43769?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
