bito-code-review[bot] commented on PR #43769:
URL: https://github.com/apache/superset/pull/43769#issuecomment-5522813340
<!-- Bito Reply -->
The issue is correct. The `EmbeddedChartResponseSchema` in
`superset/charts/schemas.py` defines `chart_id` as a field, but the
`EmbeddedChart` model uses `slice_id` to store the identifier. To resolve this,
you should update the schema to use `slice_id` instead of `chart_id` to match
the model.
```python
class EmbeddedChartResponseSchema(Schema):
uuid = fields.String()
allowed_domains = fields.List(fields.String())
slice_id = fields.String()
changed_on = fields.DateTime()
changed_by = fields.Nested(UserSchema)
```
I have reviewed the other comments in this PR. Would you like me to fetch
all of them, validate their correctness, and implement fixes for the rest as
well?
**superset/charts/schemas.py**
```
class EmbeddedChartResponseSchema(Schema):
uuid = fields.String()
allowed_domains = fields.List(fields.String())
slice_id = fields.String()
changed_on = fields.DateTime()
changed_by = fields.Nested(UserSchema)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
