bito-code-review[bot] commented on PR #43809: URL: https://github.com/apache/superset/pull/43809#issuecomment-5518505329
<!-- Bito Reply --> The issue is correct. In newer versions of `sqlglot`, the `sqlglot.parsers.starrocks` module has been removed or relocated, causing the import in `superset/sql/dialects/starrocks.py` to fail. To resolve this, you should import the StarRocks dialect directly from `sqlglot.dialects.starrocks` and avoid importing from `sqlglot.parsers.starrocks` if it is no longer available. Since the current implementation relies on `_StarRocksParser` from `sqlglot.parsers.starrocks`, you may need to check if the functionality can be achieved by extending the base `StarRocks` dialect class or by using the public API provided by `sqlglot` instead of internal parser modules. **superset/sql/dialects/starrocks.py** ``` from sqlglot import exp from sqlglot.dialects.starrocks import StarRocks as _StarRocks # from sqlglot.parsers.starrocks import StarRocksParser as _StarRocksParser <-- This is the problematic import ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
